Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning #266

Closed
wants to merge 3 commits into from
Closed

Fix deprecation warning #266

wants to merge 3 commits into from
+6,427 −15

Conversation

alexevanczuk
Copy link

@alexevanczuk alexevanczuk commented Oct 15, 2022 •
edited
Loading

Summary

Fixes #265 to prevent deprecation warnings in user consoles:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The recommended approach in the blog post is to upgrade @actions/core to 1.10.0.

When I ran npm install, I got this,

npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
(################⠂⠂) ⠧ idealTree:inflate:node_modules/assert-plus: sill inflate node_modules/assert-plus

I believe this is the cause of the large change in package-lock.json.

I tested this locally (by pointing another project at my fork) and verified it removes the deprecation warning.

Commits

  • Bump @actions/core to 1.10.0
  • npm install

@jt-nti jt-nti mentioned this pull request Oct 19, 2022
Merged
@alexevanczuk
Copy link
Author

@softprops Let me know if you'd have time to review and merge this change. If not, I'll close this PR.

@jepler
Copy link

jepler commented Oct 23, 2022

Hi! At @adafruit we use this action. Please let us know if we can help get this PR accepted.

This was referenced Oct 29, 2022
Closed
Closed
Closed
@afhoffman afhoffman mentioned this pull request Oct 29, 2022
Open
@alexevanczuk
Copy link
Author

Hey folks I'm going to close this out for now. We can always reopen it up and merge it.

In the meantime, I'll recommend two alternative approaches:

@alexevanczuk alexevanczuk deleted the ae-fix-deprecation-warning branch October 31, 2022 13:59
@alexevanczuk alexevanczuk mentioned this pull request Oct 31, 2022
Closed
@DavidWiseman DavidWiseman mentioned this pull request Oct 31, 2022
Closed
@DavidWiseman
Copy link

Hey folks I'm going to close this out for now. We can always reopen it up and merge it.

In the meantime, I'll recommend two alternative approaches:

Thanks. I've decided to replace with GH CLI.

@jepler
Copy link

jepler commented Oct 31, 2022

@tekktrik we should investigate the above options for library actions

casperdcl added a commit to iterative/shtab that referenced this pull request Nov 18, 2022
@casperdcl
build: use gh release

Verified

This commit was signed with the committer’s verified signature.
casperdcl Casper da Costa-Luis
GPG key ID: 99763689A5D97481
Verified
Learn about vigilant mode
3ce67d0 
- vis. softprops/action-gh-release#266 (comment)"
@casperdcl casperdcl mentioned this pull request Nov 18, 2022
Merged
casperdcl added a commit to iterative/shtab that referenced this pull request Nov 18, 2022
@casperdcl
build: use gh release

Verified

This commit was signed with the committer’s verified signature.
casperdcl Casper da Costa-Luis
GPG key ID: 99763689A5D97481
Verified
Learn about vigilant mode
21a7812 
- vis. softprops/action-gh-release#266 (comment)
casperdcl added a commit to AMYPAD/CuVec that referenced this pull request Nov 18, 2022
@casperdcl
build: use gh release
a3a3c05 
- vis. softprops/action-gh-release#266 (comment)
casperdcl added a commit to AMYPAD/CuVec that referenced this pull request Nov 18, 2022
@casperdcl
build: use gh release
8029240 
- vis. softprops/action-gh-release#266 (comment)
@ncfavier ncfavier mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the set-output command (deprecation warning)
3 participants
@alexevanczuk @jepler @DavidWiseman