-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Buffer indexOf with Limit #1587
Comments
Might be better to do #1208 and then all APIs get a free limiter. You can do either |
Yep, particularly since @swankjesse publicly promised to rush it. 😁
|
I have it on a branch, not that it's all that complicated. The sole impediment was that OkHttp needs to know when you hit the limit. And I can't remember if it also needs a callback when someone closes. The API was getting messy. |
Jake's WIP 2e9df10 |
That worked brilliantly, although I didn't need the full API, so I made an internal copy for now. Actually maybe I missed a case regarding "OkHttp needs to know when you hit the limit", am I missing something? |
From square/okhttp#8665
Ideally we would have
The text was updated successfully, but these errors were encountered: