Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore]: read BASE API URL from index.html #364

Closed
peppescg opened this issue Mar 3, 2025 · 0 comments · Fixed by #369
Closed

[Chore]: read BASE API URL from index.html #364

peppescg opened this issue Mar 3, 2025 · 0 comments · Fixed by #369
Assignees
@peppescg
Labels
enhancement New feature or request

Comments

@peppescg
Copy link
Collaborator

peppescg commented Mar 3, 2025 •
edited
Loading

Description

For a better and safer replacement of baseUrl, we could add the env var into the index.html and let the main.tsx read from window rather than env var directly.

This will allow users to replace the BASE_API_URL through the docker run... cmd, setting an env BASE_API_URL.

Additional Context

No response
@peppescg peppescg self-assigned this Mar 3, 2025
@peppescg peppescg added the enhancement New feature or request label Mar 3, 2025
@peppescg peppescg linked a pull request Mar 5, 2025 that will close this issue
chore: get base api url from index.html #369
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peppescg peppescg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: get base api url from index.html stacklok/codegate-ui
1 participant
@peppescg