Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] feat: node-based muxing editor #355

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Feb 28, 2025

This is just a POC. The idea is a graphical, node-based approach to configuring muxing.

This is effectively similar to the the existing approach, but has some benefits:

  • more "cool" factor
  • less repetition — you can route multiple matches to the same model

What is required to make this prod ready

  • re-ordering (the current implementation of muxing in codegate works sequentially — i.e. you pass an array of "matchers" and the first one to match dictates the routing, with a fall-through ("catch-all") case last — we would have to make this very obvious in the UI)
  • "smarter" layout
  • FIM support
  • real data — this is a UI only POC at this stage
  • validation
Screenshot 2025-02-28 at 1 42 02 AM

Copy link

stacklok-cloud-staging bot commented Feb 28, 2025

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 401ebe83:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

@coveralls
Copy link
Collaborator

coveralls commented Feb 28, 2025

Pull Request Test Coverage Report for Build 13724706155

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 22 of 89 (24.72%) changed or added relevant lines in 6 files are covered.
  • 81 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-3.1%) to 66.516%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/icons/icon-regex.tsx 1 2 50.0%
src/features/muxing/components/mux-node-matcher.tsx 1 2 50.0%
src/routes/route-mux-config.tsx 10 75 13.33%
Files with Coverage Reduction New Missed Lines %
src/mocks/msw/handlers.ts 5 77.78%
src/lib/utils.ts 8 57.14%
src/api/generated/sdk.gen.ts 10 74.36%
src/api/generated/@tanstack/react-query.gen.ts 58 69.9%
Totals Coverage Status
Change from base Build 13540948529: -3.1%
Covered Lines: 903
Relevant Lines: 1284

💛 - Coveralls

@alex-mcgovern alex-mcgovern changed the title feat: node muxing editor [POC] feat: node-based muxing editor Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants