Change the download url for lilypond for linux and windows to point correct page #4395
Conversation
prikshitsingh24
changed the title
|
@walterbender Please review. |
|
Maybe we should add MacOS too as a link and not replicate the documentation here? Plus there is another problem: https://camo.githubusercontent.com/ |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
|
@pikurasa do you think we need to maintain the screen shots of the Mac download process in our README? Is it not enough (and easier to maintain) a link to the upstream instructions? |
I don't think we need screenshots, and we should probably direct everyone to https://lilypond.org/download.html, regardless of OS. The issue with the links I see in this PR is that they're specific to a particular version of Lilypond, so we'll fall behind the most recent version at some point in the future. |
lilypond/README.md
Outdated
| @@ -19,7 +19,7 @@ Open the [LilyPond download page](http://www.lilypond.org/download.html) and dow | |||
|
|
|||
| ## Installing LilyPond | |||
| ### Installation for GNU/Linux and FreeBSD | |||
| [Read GNU/Linux Installation on the Lilypond webpage](http://www.lilypond.org/unix.html) | |||
| [Read GNU/Linux Installation on the Lilypond webpage](https://lilypond.org/doc/v2.23/Documentation/web/unix) | |||
There was a problem hiding this comment.
I recommend pointing here instead: https://lilypond.org/download.html
lilypond/README.md
Outdated
| @@ -30,11 +30,12 @@ sudo ./lilypond-2.16.2-1.linux-64.sh | |||
| ``` | |||
|
|
|||
| ### Installation for Windows | |||
| [Read Windows Installation on the Lilypond webpage](http://www.lilypond.org/windows.html) | |||
| [Read Windows Installation on the Lilypond webpage](https://lilypond.org/doc/v2.23/Documentation/web/windows) | |||
There was a problem hiding this comment.
I recommend pointing here instead: https://lilypond.org/download.html
lilypond/README.md
Outdated
|
|
||
| Download the `.exe` file and run it to launch the installation process. | ||
|
|
||
| ### Installation for Mac OS | ||
| [Read Windows Installation on the Lilypond webpage](https://lilypond.org/doc/v2.23/Documentation/web/macos-x) |
There was a problem hiding this comment.
I recommend pointing here instead: https://lilypond.org/download.html
Alternatively, you might restructure the language to say "Lilypond may be downloaded for Windows, Mac, and GNU/Linux. Complete instructions are published on their website: I recommend pointing here instead: https://lilypond.org/download.html
lilypond/README.md
Outdated
|
|
||
| Download the `.exe` file and run it to launch the installation process. | ||
|
|
||
| ### Installation for Mac OS | ||
| [Read Windows Installation on the Lilypond webpage](https://lilypond.org/doc/v2.23/Documentation/web/macos-x) | ||
| 1. Open the `.tar.bz2` file once it gets downloaded. | ||
| <img src="\images\ly_mac_1.png"></img> |
|
@prikshitsingh24 Please update as suggested. |
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
The url for both Linux and Windows now point to correct page.
Fixes: #4394