optimizing DOM manipulation in activity.js #4467
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
@apsinghdev what are your thoughts on this? |
|
@Commanderk3 I think we should first discuss how can we measure the impact of our changes. The dom changes are huge and we'd need a way to measure the result of our changes so that we know we are on the right path. |
|
@apsinghdev Yes, absolutely! Let's discuss this in the next meet. Till then I will try to come up with some more ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on optimizing the handling of DOM elements in activity.js file.
issue: #4461
Currently, in activity.js, many DOM elements are repetadely accessed uncessaarily; this makes the browser traverse DOM tree again and again, resulting in bad performance.
I am thinking of following these steps :->