Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done with Ci-CD #4472

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Done with Ci-CD #4472

wants to merge 13 commits into from

Conversation

Fareed95
Copy link

Pull Request: CI/CD Pipeline & GitHub Pages Deployment

📄 Description:

This PR addresses Issue #4284, introducing a CI/CD pipeline and automatic deployment to GitHub Pages.
Additionally, it resolves the problem where the deployment script was unintentionally triggered on forked repositories and pull requests, ensuring it only runs on merges to the master branch of the main repository.


✅ Checklist:

  • My changes adhere to the project's contribution guidelines.
  • Code changes are implemented and tested.
  • The CI/CD pipeline is functioning as expected.
  • Deployment to GitHub Pages is successful.

💡 What This PR Does:

  • Sets up a robust CI/CD pipeline for automated testing and deployment.
  • Deploys the project to GitHub Pages on merge to master only.
  • Prevents unintended execution of the deployment script on forked PRs or regular pushes.

🔗 Related Issues:

Closes #4284


🧪 Testing Instructions:

  1. Fork the Repository and create a PR—the deployment should not trigger.
  2. Merge a PR into master—the deployment should trigger.

💬 Additional Notes:

If any issues arise during the deployment process, feel free to tag me for assistance!

@justin212407 please check out this

Copy link

✅ All Jest tests passed! This PR is ready to merge.

@justin212407
Copy link
Member

justin212407 commented Feb 28, 2025

@Fareed95 this issue was already being worked upon in #4290. Please look into that before opening a PR. We should avoid having duplicate works. As i mentioned in the comment please only take up issues which are not being worked upon as this creates duplicate works.

@Fareed95
Copy link
Author

Fareed95 commented Mar 3, 2025

Hey @justin212407 , I understand your concern. I took up this issue because the existing PR (#4290) has been in draft for over a month without any progress. Since it seemed inactive, I worked on it to move things forward. Sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants