Refactor _() function to improve translation handling and case preservation #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All Jest tests passed! This PR is ready to merge. |
Closed
walterbender
reviewed
Mar 6, 2025
js/utils/utils.js
Outdated
| if (!translated || translated === text) { | ||
| translated = document.webL10n.get(text.toLowerCase()); | ||
| } | ||
| // Helper function to get translation with case matching |
There was a problem hiding this comment.
ohh sorry about that, fixed!
|
✅ All Jest tests passed! This PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the
_()function to improve its translation handling and case preservation logic. Key changes include:getTranslationWithCase) to simplify translation logic and handle case variations.Why is this change needed?
The existing function had repetitive logic and lacked a structured approach to handling translations with case variations. This refactor makes the code more readable, maintainable, and efficient.