-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive Unit Tests for Pitch & Tone Block Components #4480
base: master
Are you sure you want to change the base?
Conversation
✅ All Jest tests passed! This PR is ready to merge. |
Please add a license (see the other test files) to these files. |
✅ All Jest tests passed! This PR is ready to merge. |
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender this PR is not following our guide to add tests instead of mocking variables and function in the test itself it is creating an another mock.js file which is strictly prohibited as we get into trouble as someone did this in the synthutils i think @PriyamvadaShah you need to refactor your test looking at our adding test guide in js directory |
@PriyamvadaShah also you are not following the actual nomenclature for the test file we are doing in MB again you are not supposed to edit the .json file please do follow the guide and refactor all the changes suggested according to that |
@omsuneri Thank you so much for pointing these out. Will make changes to make sure I adhere to the guidelines! |
@PriyamvadaShah also please mock the fun in the test itself only don't create another mock.js as it becomes very hard for debugging the failure of any test in future |
This adds comprehensive Jest test coverage for the Pitch and Tone block components, focusing on proper initialization, error handling, and integration behavior. The tests verify both individual block functionality and interactions between related blocks, ensuring that musical operations (key signature, scale, transposition, oscillators, and audio effects) work correctly.
PitchBlocks Tests:
ToneBlocks Tests:
Designed these in order to test that the PitchBlocks and ToneBlocks work as intended and cover all edge cases.
Kindly review this PR and suggest any changes, if required :)