-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix the test of toolabar and the planet #4490
base: master
Are you sure you want to change the base?
Conversation
✅ All Jest tests passed! This PR is ready to merge. |
Thank you for looking into this Ajeet, were the tests broken due to some recent PRs? Earlier all tests ran fine. |
@BeNikk Actually, I don't know which commit introduced this. I ran the tests and found it failing. |
Since the Planet had been down, I am not sure this test would ever have run properly. Now that the Planet is back up, we can sort things out. |
@walterbender Actually, this issue is related only to the frontend, i.e., the icon, text, etc., and is independent of the functionality of the planet. |
@walterbender @apsinghdev Actually when i wrote this test for planet, it was redirecting the user to planet page by the click of the icon and ensuring whether the page exist or not. |
@BeNikk If you run it now, it breaks. Try to run the cypress test and let me know if it breaks to your side or not? |
On the latest pull, all the tests were running fine on my end, Strange! |
The tests pass on my system. |
@walterbender @BeNikk Can you please confirm that I am running it the same way as you do? Screen.Recording.2025-03-04.at.9.23.49.PM.mov |
I think you have not started your server in the background as the tests were skipped, MB should be running locally before running these tests |
When I run |
I am not sure of this, when i don't start the server i get result something similar to what ajeet sees |
@BeNikk Still the same result. testss.mp4 |
Have you checked the terminal after that process? |
@apsinghdev I think loading time in different operating systems and browsers might differ slightly and because of that tests are failing, what do you think, I'm using an ubuntu machine |
I am using mac and it's dev env is pretty much the same as ubuntu as it's based on Unix. Also we are using a chromium image for testing that is the same on each machine ig. |
fixes: #4489
This PR fixes the tests related to the toolbar and the planet.
@walterbender Please have a look.