-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add License Header to top-level README.md file #4492
Add License Header to top-level README.md file #4492
Conversation
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender Please review. Also, should I update the GitHub Actions workflow which is using the Ubuntu 20.04 runner, which is scheduled for deprecation and removal in a separate PR? |
Not sure if this is the correct place for this. It is applicable to all of the code we write for the project, not just tests. The issue was that we had completely neglected to do this for the tests. |
Would you like me to close the PR, or should we update it to apply the license header more broadly? |
Maybe move the text to the Contributing section of the top-level README.md file? |
Sure. I would rebase and add it there. |
ccea520
to
cca24c5
Compare
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender Please review. |
Maybe rephrase this: "All contributors must include the following license header in every file they modify or create within the project:" "Music Blocks is licensed under the AGPL. If you add a new file to the Music Blocks code base, please be sure to include a license header as per below:" |
cca24c5
to
5ccae67
Compare
✅ All Jest tests passed! This PR is ready to merge. |
Added the suggestions. Please review. |
Summary
This PR adds the required license header to the test guide, ensuring consistency across all test files.