Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add License Header to top-level README.md file #4492

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Ubayed-Bin-Sufian
Copy link
Contributor

Summary

This PR adds the required license header to the test guide, ensuring consistency across all test files.

Copy link

github-actions bot commented Mar 4, 2025

✅ All Jest tests passed! This PR is ready to merge.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

@walterbender Please review.

Also, should I update the GitHub Actions workflow which is using the Ubuntu 20.04 runner, which is scheduled for deprecation and removal in a separate PR?

@walterbender
Copy link
Member

Not sure if this is the correct place for this. It is applicable to all of the code we write for the project, not just tests. The issue was that we had completely neglected to do this for the tests.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

Not sure if this is the correct place for this. It is applicable to all of the code we write for the project, not just tests. The issue was that we had completely neglected to do this for the tests.

Would you like me to close the PR, or should we update it to apply the license header more broadly?

@walterbender
Copy link
Member

Maybe move the text to the Contributing section of the top-level README.md file?

@Ubayed-Bin-Sufian
Copy link
Contributor Author

Maybe move the text to the Contributing section of the top-level README.md file?

Sure. I would rebase and add it there.

@Ubayed-Bin-Sufian Ubayed-Bin-Sufian changed the title Add License Header to Test Guide Add License Header top-level README.md file Mar 4, 2025
@Ubayed-Bin-Sufian Ubayed-Bin-Sufian changed the title Add License Header top-level README.md file Add License Header to top-level README.md file Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

✅ All Jest tests passed! This PR is ready to merge.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

@walterbender Please review.

@walterbender
Copy link
Member

Maybe rephrase this: "All contributors must include the following license header in every file they modify or create within the project:"

"Music Blocks is licensed under the AGPL. If you add a new file to the Music Blocks code base, please be sure to include a license header as per below:"

Copy link

github-actions bot commented Mar 5, 2025

✅ All Jest tests passed! This PR is ready to merge.

@Ubayed-Bin-Sufian
Copy link
Contributor Author

Ubayed-Bin-Sufian commented Mar 5, 2025

Maybe rephrase this: "All contributors must include the following license header in every file they modify or create within the project:"

"Music Blocks is licensed under the AGPL. If you add a new file to the Music Blocks code base, please be sure to include a license header as per below:"

Added the suggestions. Please review.
Thanks a lot for your guidance.

@walterbender walterbender merged commit beed91a into sugarlabs:master Mar 5, 2025
5 checks passed
@Ubayed-Bin-Sufian Ubayed-Bin-Sufian deleted the doc_enhance_10 branch March 5, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants