Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: unify NaN phrasing, editorial followups to #3532 #3547

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Editorial: unify NaN phrasing, editorial followups to #3532 #3547

merged 2 commits into from
Mar 6, 2025

Conversation

michaelficarra
Copy link
Member

  • unify phrasing in RawBytesToNumeric and NumericToRawBytes
  • prefer "NaN" over "the NaN Number value"
  • rename v alias in DataView.prototype methods to view

bakkot
bakkot reviewed Mar 3, 2025
View reviewed changes
@michaelficarra michaelficarra requested review from bakkot and syg March 5, 2025 03:41
bakkot
bakkot reviewed Mar 5, 2025
View reviewed changes
bakkot
bakkot reviewed Mar 5, 2025
View reviewed changes
bakkot
bakkot reviewed Mar 5, 2025
View reviewed changes
@bakkot bakkot added the editor call to be discussed in the next editor call label Mar 5, 2025
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Mar 5, 2025
bakkot
bakkot reviewed Mar 5, 2025
View reviewed changes
syg
syg approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Mar 6, 2025
ljharb pushed a commit that referenced this pull request Mar 6, 2025
@michaelficarra @ljharb
Editorial: make phrasing in RawBytesToNumeric match NumericToRawBytes (…
48925f6 
…#3547)
@ljharb ljharb force-pushed the GH-3532-followup branch from 836dd48 to 48925f6 Compare March 6, 2025 18:28
@ljharb ljharb force-pushed the GH-3532-followup branch from 48925f6 to ddae0a9 Compare March 6, 2025 18:38
@ljharb ljharb changed the title editorial follow-ups to #3532 Editorial: unify NaN phrasing, editorial followups to #3532 Mar 6, 2025
@ljharb ljharb merged commit ddae0a9 into main Mar 6, 2025
8 checks passed
@ljharb ljharb deleted the GH-3532-followup branch March 6, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syg syg

@bakkot bakkot

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelficarra @syg @bakkot @ljharb