Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operations specific to DateTimeFormat should have names indicating that #961

Open
gibson042 opened this issue Feb 18, 2025 · 1 comment
Open

Operations specific to DateTimeFormat should have names indicating that #961

gibson042 opened this issue Feb 18, 2025 · 1 comment

Comments

@gibson042
Copy link
Contributor

(originally posted by @gibson042 in #923 (comment))

e.g., {Basic,BestFit}Matcher → DateTimeFormat{Basic,BestFit}Matcher
@gibson042 gibson042 mentioned this issue Feb 18, 2025
Merged
@anba
Copy link
Contributor

anba commented Feb 18, 2025

Maybe keep "FormatMatcher" together to match the constructor option "formatMatcher"? That means: {Basic,BestFit}DateTimeFormatMatcher.

Intl.DateTimeFormat is currently the only Intl constructor which accepts a "formatMatcher" option, so there's no latent ambiguity about the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gibson042 @anba