Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hermes command line arguments are incorrect #125

Open
gibson042 opened this issue Oct 15, 2022 · 0 comments · May be fixed by #138
Open

hermes command line arguments are incorrect #125

gibson042 opened this issue Oct 15, 2022 · 0 comments · May be fixed by #138

Comments

@gibson042
Copy link
Contributor

https://github.com/bterlson/eshost/blob/d1809998d823383a38ed022c0cda4245bd02c61b/lib/agents/hermes.js#L35 uses -fenable-tdz, which was renamed to -Xenable-tdz as of hermes v0.10.0: facebook/hermes@f811a0e
@gibson042 gibson042 mentioned this issue Oct 15, 2022
Closed
gibson042 added a commit to gibson042/eshost that referenced this issue Oct 3, 2023
@gibson042
Use the correct CLI option to enable TDZ in Hermes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ea85e19 
Fixes tc39#125
@gibson042 gibson042 linked a pull request Oct 3, 2023 that will close this issue
Open
leotm added a commit to leotm/eshost that referenced this issue Jan 31, 2025
@leotm
fix: hermes unknown command line argument '-fenable-tdz'
0a8e3bd 
- fix: tc39#125
- ref: facebook/hermes#839
@leotm leotm mentioned this issue Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@gibson042