Temporal: Reorganize calendar and wrong-type tests #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brageh01
changed the title
|
Issue: #3873 |
|
About the questions: my sense is that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to:
Merged
calendar-number.jsandcalendar-wrong-type.js, due to no special behaviour of number to be tested.Extracted string tests to
calendar-iso-string.jsand renamed the file tocalendar-invalid-iso-string.js, due to the contents of the file initially testing invalid ISO strings.Questions:
Are change to be made for the
argument-propertybag-calendar-number.jsandargument-propertybag-calendar-wrong-type.jsfiles as well?However, I notice that the
argument-propertybag-calendar-iso-string.jsactually tests for valid and not invalid ISO strings here. Perhaps create ainvalid-iso-string.js?Is the "merge-and-extract» also relevant for
relativeto-propertybag-calendar-number.jsandrelativeto-propertybag-calendar-wrong-type.js?