Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] - no progress tracking for Jobs w/ ID 0 #1205

Draft
wants to merge 61 commits into
base: main
Choose a base branch
from
Draft

[chore] - no progress tracking for Jobs w/ ID 0 #1205

wants to merge 61 commits into from

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Mar 26, 2023

  • We do not need the overhead of a cache or progress tracking for non-stateful runs. This would include all runs using the CLI.

ahrav added 30 commits March 19, 2023 13:44
@ahrav
Add in-memory caching lib, used by the GCS source.
465e738
@ahrav
Use cache for tracking progress for the GCS source.
354bee6
@ahrav
fix merge issue.
2033a9d
@ahrav
fix merge issue.
3252664
@ahrav
fix test.
dd6aa7d
@ahrav
Fix static check.
7a2698d
@ahrav
Add test for NewWithData.
7ec39f5
@ahrav
Use cache for tracking progress for the GCS source.
46d598c
@ahrav
fix merge issue.
0e8bafc
@ahrav
fix merge issue.
f1a6497
@ahrav
fix test.
baac8ab
@ahrav
Merge branch 'use-cache-gcs-source-progress' of github.com:trufflesec…
4116e4a 
…urity/trufflehog into use-cache-gcs-source-progress
@ahrav
update comment.
314ffb3
@ahrav
update comments.
a558031
@ahrav
Use cache for tracking progress for the GCS source.
08fa068
@ahrav
fix merge issue.
4765d5f
@ahrav
fix merge issue.
c0819b6
@ahrav
fix test.
076d546
@ahrav
Merge branch 'use-cache-gcs-source-progress' of github.com:trufflesec…
f55e861 
…urity/trufflehog into use-cache-gcs-source-progress
@ahrav
Include md5 hash to the object struct.
249575c
@ahrav
merge main.
4c42018
@ahrav
remove unused dep.
565c026
@ahrav
address comments.
d563a40
@ahrav
Add exists method.
1d1e468
@ahrav
Use cache for tracking progress for the GCS source.
8b47b41
@ahrav
fix merge issue.
b7091aa
@ahrav
fix merge issue.
b3ac546
@ahrav
fix test.
baacc8d
@ahrav
rebase.
d7e3cd7
@ahrav
resolve conflicts.
6a18b2e
ahrav and others added 26 commits March 20, 2023 15:24
@ahrav
fix merge issue.
c695415
@ahrav
fix merge issue.
efca232
@ahrav
fix test.
566eb56
@ahrav
rebase.
5db3c7e
@ahrav
rebase.
01463c0
@ahrav
merge main.
e07fdf0
@ahrav
split encode resume by comma.
02b1b59
@ahrav
Merge branch 'main' into use-cache-gcs-source-progress
298e9df
@ahrav
update comment.
36f6120 
add comment for shouldCache.

remove redundant return.
@ahrav
use md5 instead of name.
cfca348
@ahrav
update tests.
5822bd8
@ahrav
Include md5 hash to the object struct.
c63c88d
@ahrav
use md5 instead of name.
ed9de7e
@ahrav
update tests.
583ecf4
@ahrav
Merge branch 'use-md5-hash-for-resuming-key' of github.com:trufflesec…
c72b769 
…urity/trufflehog into use-md5-hash-for-resuming-key
@ahrav
Use a persistable cache.
1b9ae19
@ahrav
fix merge.
b3091e9
@ahrav
fix merge.
d3dc8bc
@ahrav
Include md5 hash to the object struct.
cf5b670
@ahrav
use md5 instead of name.
8842d4a
@ahrav
update tests.
a405c90
@ahrav
merge head.
a2dad05
@ahrav
use md5 instead of name.
243e673
@ahrav
[chore] - log enumeration duration (#1187)
1cbc31b 
* log enumeration duration.

* use defer to print enumeration duration stat.

* remove temp var.
@dependabot @ahrav
Bump actions/setup-go from 3 to 4 (#1191)
d1ed011 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ahrav
Use the cache only for jobIDs != 0
b58f6d4
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ahrav
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @CLAassistant