added flyio detector #2381
Open
added flyio detector #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zricethezav
reviewed
Feb 12, 2024
| var ( | ||
| defaultClient = common.SaneHttpClient() | ||
| // Make sure that your group is surrounded in boundary characters such as below to reduce false positives. | ||
| keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"flyio"}) + `\b([a-zA-Z0-9_]{47})\b`) |
There was a problem hiding this comment.
@lonmarsDev all the tokens I generated started with fo1_. Does that match what you were seeing? If so we should probably add fo1_ as part of this regex and to the keywords.
There was a problem hiding this comment.
Fly.io has a few legacy token formats that are no longer issued, but still might exist in the wild:
[a-zA-Z0-9_-]{43}fm1[ar]_[a-zA-Z0-9+\/]={0,2}
And two formats that we currently issue
fo1_[a-zA-Z0-9_-]{43}fm2_[a-zA-Z0-9+\/]={0,2}
|
We might want to rename this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Explain the purpose of the PR.
Checklist:
make test-community)?make lintthis requires golangci-lint)?