[perf] - Optimize Chunk Size Handling for Improved I/O and Memory Efficiency #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
force-pushed
the
perf-optimize-chunker
branch
4 times, most recently
from
78d485b to
ecf8ef7
Compare
ahrav
force-pushed
the
perf-optimize-chunker
branch
from
ecf8ef7 to
36788ec
Compare
rosecodym
reviewed
Jul 8, 2024
|
|
2 tasks
ahrav
force-pushed
the
perf-optimize-chunker
branch
from
a9e22b8 to
025bac2
Compare
ahrav
force-pushed
the
perf-optimize-chunker
branch
from
6be2132 to
5970cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refines the chunk size handling mechanism in our file processing pipeline to optimize I/O operations and memory usage. The changes include updating the logic for determining chunk sizes based on file sizes, using appropriate thresholds, and setting chunk sizes that align better with common file sizes and I/O efficiency.
The new chunk size logic is integrated into the file handling processes to ensure efficient processing.
Bechmarks:
~6GB Filesystem Scan
BEFORE: (~49s)
AFTER: (~37s)
Checklist:
make test-community)?make lintthis requires golangci-lint)?