Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] - modify sane client #3157

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[chore] - modify sane client #3157

wants to merge 1 commit into from

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Aug 2, 2024

Description:

This pull request modifies the SaneClient used by our detectors to improve connection reuse.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav marked this pull request as ready for review August 2, 2024 16:08
@ahrav ahrav requested a review from a team as a code owner August 2, 2024 16:08
@ahrav ahrav requested a review from a team August 2, 2024 16:08
0x1
0x1 reviewed Aug 2, 2024
View reviewed changes
pkg/common/http.go
Timeout: 2 * time.Second,
KeepAlive: 5 * time.Second,
Timeout: 3 * time.Second,
KeepAlive: 30 * time.Second,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a huge increase

@ahrav
Copy link
Collaborator Author

ahrav commented Aug 2, 2024

Converting to Draft for now. Will address later.

@ahrav ahrav marked this pull request as draft August 2, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x1 0x1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @0x1