Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed verification endpoint and verification logic for brand fetch #3470

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Next Next commit
fix: fixed verification endpoint and verification logic
  • Loading branch information
sahil9001 committed Nov 9, 2024
commit 81f4c1974ca2e5a1c7a2478a59bae64db8969b4f
10 changes: 4 additions & 6 deletions pkg/detectors/brandfetch/brandfetch.go
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ var (
client = common.SaneHttpClient()

// Make sure that your group is surrounded in boundary characters such as below to reduce false positives.
keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"brandfetch"}) + `\b([0-9A-Za-z]{40})\b`)
keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"brandfetch"}) + `\b([a-zA-Z0-9=]{44})`)
)

// Keywords are used for efficiently pre-filtering chunks.
@@ -48,15 +48,13 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result
}

if verify {
payload := strings.NewReader(`{
"domain": "www.example.com"
}`)
req, err := http.NewRequestWithContext(ctx, "POST", "https://api.brandfetch.io/v1/color", payload)
// API upgraded to v2 from v1, new API doc:
req, err := http.NewRequestWithContext(ctx, "GET", "https://api.brandfetch.io/v2/brands/google.com", nil)
if err != nil {
continue
}
req.Header.Add("Content-Type", "application/json")
req.Header.Add("x-api-key", resMatch)
req.Header.Add("Authorization", "Bearer "+resMatch)
res, err := client.Do(req)
if err == nil {
defer res.Body.Close()