Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed verification endpoint and verification logic for brand fetch #3470

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+208 −11
Open

fix: fixed verification endpoint and verification logic for brand fetch #3470

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81f4c19
fix: fixed verification endpoint and verification logic
sahil9001 Oct 18, 2024
360d6e5
fix: added API doc link
sahil9001 Oct 21, 2024
29f2ea4
feat: introduced a new detector for apis
sahil9001 Nov 9, 2024
ca674ad
feat: added versioner impl
sahil9001 Oct 28, 2024
bdecb90
Merge branch 'main' into brandfetch-verfication-endpoint-fix
kashifkhan0771 Nov 12, 2024
c11d340
Merge branch 'main' into brandfetch-verfication-endpoint-fix
kashifkhan0771 Nov 13, 2024
eff92c9
Merge branch 'main' into brandfetch-verfication-endpoint-fix
kashifkhan0771 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: added versioner impl 
Signed-off-by: Sahil Silare <sahilsilare@gmail.com>
  • Loading branch information
@sahil9001
sahil9001 committed Nov 9, 2024
commit ca674ad05e2a3ffde8eec7e3d6aaca8a1da5f3ea
3 changes: 3 additions & 0 deletions pkg/detectors/brandfetch/v1/brandfetch.go
View file
Original file line number Diff line number Diff line change
@@ -14,8 +14,11 @@ import (

type Scanner struct{}

func (s Scanner) Version() int { return 1 }

// Ensure the Scanner satisfies the interface at compile time.
var _ detectors.Detector = (*Scanner)(nil)
var _ detectors.Versioner = (*Scanner)(nil)
var (
client = common.SaneHttpClient()

4 changes: 3 additions & 1 deletion pkg/detectors/brandfetch/v2/brandfetch.go
View file
Original file line number Diff line number Diff line change
@@ -14,9 +14,11 @@ import (

type Scanner struct{}

func (s Scanner) Version() int { return 2 }

// Ensure the Scanner satisfies the interface at compile time.
var _ detectors.Detector = (*Scanner)(nil)

var _ detectors.Versioner = (*Scanner)(nil)
var (
client = common.SaneHttpClient()