Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub Realtime authentication #3929

Merged
merged 21 commits into from
Feb 26, 2025
Merged

Enable GitHub Realtime authentication #3929

merged 21 commits into from
Feb 26, 2025

Conversation

rosecodym
Copy link
Collaborator

@rosecodym rosecodym commented Feb 21, 2025

Description:

GitHub Realtime needs to be able to authenticate. This PR adds relevant fields to the relevant protobuf message, and exports/tweaks some stuff from the github source package to permit its (eventual) use by the GitHub Realtime implementation:

  • The Connector interface and its constructors are now exported
  • Connector.Clone now accepts additional clone arguments
  • The github-specific connection construction has been moved into github.go
    • The injected rate limit handler no longer accepts error reporters that it never uses

I also added an API endpoint field to the GitHub Realtime proto message, because we need that too and I was here.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rosecodym rosecodym marked this pull request as ready for review February 21, 2025 20:35
@rosecodym rosecodym requested review from a team as code owners February 21, 2025 20:35
Copy link
Collaborator

@zricethezav zricethezav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns here

@rosecodym rosecodym merged commit ae793d7 into main Feb 26, 2025
13 checks passed
@rosecodym rosecodym deleted the export-github-connector branch February 26, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants