Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable github v1, it is no longer supported #3934

Closed
wants to merge 1 commit into from
Closed

Disable github v1, it is no longer supported #3934

wants to merge 1 commit into from

Conversation

dustin-decker
Copy link
Contributor

@dustin-decker dustin-decker commented Feb 25, 2025 •
edited
Loading

Description:

GitHub support has informed us that the v1 token is no longer supported. It has always been a noisy format due to looking like a sha1 hash.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@dustin-decker dustin-decker requested review from a team as code owners February 25, 2025 17:24
@rgmz
Copy link
Contributor

rgmz commented Feb 25, 2025

Unless they've formally blocked all tokens, the v1 format is still supported by both github.com and GHES.

The amount of false-positives can be cut down by doing stuff like #3658, #3664.

@dustin-decker
Copy link
Contributor Author

Yeah, I just confirmed the same from our integration test which is still passing.

@dustin-decker dustin-decker marked this pull request as draft February 25, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustin-decker @rgmz