Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] - check for invalid_grant to avoid setting verification error #3935

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Feb 25, 2025

Description:

This PR checks for the "invalid_grant" error string to prevent setting a verification error on a finding, treating it as unverified instead.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav requested a review from a team February 25, 2025 19:40
@ahrav ahrav marked this pull request as ready for review February 25, 2025 19:50
@ahrav ahrav requested a review from a team as a code owner February 25, 2025 19:50
@nabeelalam nabeelalam merged commit cc0e79a into main Feb 27, 2025
12 of 13 checks passed
@nabeelalam nabeelalam deleted the bug-fix-gcp-detector-verification-error branch February 27, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants