[Feature] Detector implementation for Azure API Management Direct Management Key #3938
+371
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
reviewed
Feb 26, 2025
| s1 := detectors.Result{ | ||
| DetectorType: detectorspb.DetectorType_AzureDirectManagementKey, | ||
| Raw: []byte(baseUrl), | ||
| RawV2: []byte(baseUrl + primaryKey), |
There was a problem hiding this comment.
Can we start making RawV2 structured in new detectors? #3634 (comment)
| var ( | ||
| defaultClient = common.SaneHttpClient() | ||
| urlPat = regexp.MustCompile(`https://([a-z0-9][a-z0-9-]{0,48}[a-z0-9])\.management\.azure-api\.net`) // https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.APIM.Name/ | ||
| primaryKeyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"azure"}) + `\b([a-zA-Z0-9+\/-]{86,88}\b={0,2})`) // Base64-encoded primary key |
There was a problem hiding this comment.
@rgmz Initially I copied that regex from another detector, Azure Storage. After your comment, I generated 20 times a key and confidently say that all of them ended with [a-zA-Z0-9]==. Updated the regex.
code refactoring, remove unnecessary code. updated the description of detector. reduce the expiry to 5 seconds.
refactor variable name for better understanding.
abmussani
force-pushed
the
azuredirectmanagementapikey-detector-impl
branch
from
eb37f00 to
a76aa3d
Compare
rgmz
reviewed
Feb 28, 2025
| var ( | ||
| defaultClient = common.SaneHttpClient() | ||
| urlPat = regexp.MustCompile(`https://([a-z0-9][a-z0-9-]{0,48}[a-z0-9])\.management\.azure-api\.net`) // https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.APIM.Name/ | ||
| keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"azure", ".management.azure-api.net"}) + `\b([a-zA-Z0-9+\/]{83,85}[a-zA-Z0-9]==)`) // pattern for both Primary and secondary key |
There was a problem hiding this comment.
\b isn't valid when beside / or +.
There was a problem hiding this comment.
This has bitten me so many times... 😭
There was a problem hiding this comment.
Updated the regex but AzureContainerRegistry Detector has the similar issue. right ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements a new Detector for Azure Direct management API key. This detector looks for direct manage url and keys (Primary or Secondary), generates a access token with expiry of 5 seconds (to avoid leakage) and verify the credentials based on generated values.
Test Output:
Checklist:
make test-community)?make lintthis requires golangci-lint)?