-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Detector implementation for Azure API Management Direct Management Key #3938
Open
abmussani
wants to merge
11
commits into
trufflesecurity:main
Choose a base branch
from
abmussani:azuredirectmanagementapikey-detector-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+392
−6
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d46cec4
azuredirectmanagementapikey detector implementation and tests
abmussani 3efd81c
add reference url
abmussani 4378691
use sanehttpclient
abmussani f68b002
better regex
abmussani c70ca94
add prefix regex for key pattern
abmussani 159a593
some refactoring
abmussani 13b3967
cleanup some unnecessary logic for expiry formatting.
abmussani a76aa3d
improvise the regex to increase confidence level.
abmussani 70511c8
remove \b from regex
abmussani 82b61f7
implemented CustomFalsePositiveChecker interface.
abmussani c8b79b8
Merge branch 'main' into azuredirectmanagementapikey-detector-impl
abmussani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
improvise the regex to increase confidence level.
refactor variable name for better understanding.
- Loading branch information
commit a76aa3d5904b8fa4cda4ec1459fd376bc64a3ad3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\b
isn't valid when beside/
or+
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has bitten me so many times... 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the regex but AzureContainerRegistry Detector has the similar issue. right ?