[bug] - Ensure detector HTTP clients share the same timeout set at runtime #3946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the way we handle the user-supplied
detectorTimeout
so that it also applies to the underlying HTTP clients used by the detectors. Previously, we only set the timeout on the per-detectorcontext
, but the actual HTTP client for detectors still used a default timeout value. Now, when the CLI flag detector-timeout is set, we call a function to override theDetectorHttpClientWithLocalAddresses
andDetectorHttpClientWithNoLocalAddresses
timeouts.This ensures consistency between the detector code’s context timeout and the HTTP client’s timeout.
I also updated the default timeout to match the previous
detectionTimeout
value and modified thedetectionTimeout
variable to use the sameDefaultResponseTimeout
from ourdetectors
package.Checklist:
make test-community
)?make lint
this requires golangci-lint)?