Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LaunchDarkly Token Analyzer #3948
LaunchDarkly Token Analyzer #3948
Changes from 1 commit
36e64af
1c92298
f143fa8
b840782
aab2c0a
9806026
cc2ac00
8ff00ae
745868e
6d3b8fa
6902b03
746e4fb
8452bdd
d445b25
25356be
4235470
143947a
8a0561a
deccdd9
8d6265f
08cdc2f
47cdd0c
1c61fce
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I've found it helpful to use
mu
almost like a "hat" for the resource(s) it protects by placing it directly above them. This makes it visually clear what it's guarding and can even replace the need for a comment.That said, I’m not entirely sure which resources
mu
is protecting in this case. 🤔 This is definitely an opinionated take, so feel free to ignore it! 🤣I forget where I first read about this, but here is a separate article about it. 😅
Ex: