Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumeration jobs should not consume concurrency slots #3952

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

dustin-decker
Copy link
Contributor

@dustin-decker dustin-decker commented Mar 3, 2025

Description:

Enumeration jobs should not consume concurrency slots since they don't consume significant resources and we want to ensure that scans are occuring.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@dustin-decker dustin-decker requested review from a team as code owners March 3, 2025 21:39
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that enumeration jobs are consuming all the concurrency slots, preventing actual scanning from running?

@dustin-decker
Copy link
Contributor Author

dustin-decker commented Mar 3, 2025

Is it possible that enumeration jobs are consuming all the concurrency slots, preventing actual scanning from running?

Yes, this can happen right now. I believe Casey observed it on main on Friday.

@dustin-decker dustin-decker merged commit 9a483c9 into main Mar 4, 2025
12 of 13 checks passed
@dustin-decker dustin-decker deleted the enumerate-concurrency branch March 4, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants