Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Iteratively track dependency-depth information for all entities such that we can stream entities to UCM clients in dependency-first order which allows them to save entities as soon as they're received rather than needing to do a client-side sort.
This also reduces required memory usage on the client, and makes the download more robust against Ctrl-c, since you can pick up from where you left off (the stream will skip any pre-saved entities).
Implementation notes
When an entity is saved, set its depth to
max(depth of all dependencies) + 1
.When streaming entities to client, sort by depth ASC.
Set sort mode of stream to Dependencies First.
Test coverage
Loose ends
There's a corresponding improvement in UCM to better parallelize the download stream here: unisonweb/unison#5593