-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/asolovev add comm profiling #2957
base: main
Are you sure you want to change the base?
Dev/asolovev add comm profiling #2957
Conversation
/intelci: run |
/intelci: run |
/intelci: run |
@Alexandr-Solovev I get a segmentation fault after the first run when running some algorithms repeatedly. Example code that segfaults after a few iterations: import numpy as np
import warnings
from sklearnex.linear_model import LinearRegression
rng = np.random.default_rng(seed=123)
m = 50_000
n = 100
for rep in range(5):
X = rng.random(size=(m,n))
y = rng.random(size=m)
with warnings.catch_warnings():
warnings.simplefilter("ignore", FutureWarning)
LinearRegression(fit_intercept=False).fit(X, y) The segfault is not encountered when using the main branch of oneDAL. |
@Alexandr-Solovev After this PR, would building with makefile option |
@Alexandr-Solovev If this commit gets merged into the main branch, it then fails to compile sklearnex with the resulting library:
|
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s): #6 (for example)
Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance