-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bazel 8.0.0 #3035
Upgrade to Bazel 8.0.0 #3035
Conversation
/intelci: run |
build -c opt \ | ||
--incompatible_enable_cc_toolchain_resolution \ | ||
--incompatible_require_linker_input_cc_api | ||
--incompatible_require_linker_input_cc_api \ | ||
--noincompatible_disallow_empty_glob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs on this aren't super clear to me - what would happen if this flag is not added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Bazel 8.0, the flag --incompatible_disallow_empty_glob will default to true. This means that the allow_empty argument defaults to False on all glob calls. In Bazel 7.0 --incompatible_disallow_empty_glob defaulted to False and the allow_empty argument defaults to True on all glob calls. Some of the glob calls in the project return empty list, so in bazel 8.0 those glob calls that return empty list error out without setting allow_empty set to true.
/intelci: run |
/intelci: run |
1 similar comment
/intelci: run |
…ry_bazel_up_grade
…/oneDAL into retry_bazel_up_grade
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think this should solve the dangling reference issue, but would nevertheless be ideal to have a valgrind run executing this jaccard/vertex algorithm code just to make sure.
Description
Changes to upgrade to Bazel 8.0.0
All of these changes can be found in the bazel migration guide (https://bazel.build/external/migration)
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance