Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP, CI, enhancement] enforce ABI checking of linux DPCPP build #3080

Draft
wants to merge 156 commits into
base: main
Choose a base branch
from

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Feb 18, 2025

Description

Address unwritten rule to oneDAL codebase with testing.

Follow up: in https://github.com/uxlfoundation/oneDAL/blob/main/cpp/daal/src/algorithms/svm/svm_train_boser_batch_fpt_dispatcher.cpp#L31 and https://github.com/uxlfoundation/oneDAL/blob/main/cpp/daal/src/algorithms/svm/svm_train_thunder_batch_fpt_dispatcher.cpp#L31
are different from all other algorithms in how it is then used in oneDAL: https://github.com/uxlfoundation/oneDAL/blob/main/cpp/oneapi/dal/algo/svm/backend/cpu/train_cls_kernel.cpp#L49 in that its using Impls as well as the kernels. This is left in as is to preserve ABI, but should be made consistent for the next major release.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@icfaust icfaust added the infra label Feb 18, 2025
@icfaust
Copy link
Contributor Author

icfaust commented Mar 1, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Mar 1, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Mar 1, 2025

/intelci: run

@icfaust icfaust force-pushed the dev/ABI_verification branch from 52e6614 to 10cc2df Compare March 3, 2025 11:07
@icfaust
Copy link
Contributor Author

icfaust commented Mar 3, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Mar 4, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Mar 4, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Mar 4, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Mar 4, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Mar 5, 2025

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Mar 5, 2025

/intelci: run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant