Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI versions #1710

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Upgrade CI versions #1710

merged 9 commits into from
Jul 24, 2024

Conversation

julianmi
Copy link
Contributor

@julianmi julianmi commented Jul 18, 2024

This PR proposes to upgrade the runners' versions to the latest OS to keep the CI running on current environments. This was noticed by @danhoeflinger in #1479 (comment).

  • Ubuntu 20.04 -> ubuntu-latest (currently 22.04)
  • Windows Server 2019 -> windows-latest (currently 2022)
  • macOS 13 -> macos-latest (currently 14)

It further upgrades the following GitHub actions:

  • actions/checkout: warns about using deprecated Node.js 16
  • actions/setup-python: warns about using deprecated Node.js 16
  • actions/upload-artifact: warns about deprecation

I've also increased the build concurrency to 4 on Linux and Windows to match the core counts on the latest runners. This reduces the test times for these configurations.

@timmiesmith
Copy link
Contributor

There is a known issue with the use of checkout@v4 and Ubuntu 22.04. See actions/checkout#1667. I'm not aware of a workaround at this point so I don't think it's possible to make all of the proposed changes in the set of move to the latest Ubuntu, Node20, and checkout@v4.

@danhoeflinger
Copy link
Contributor

Do we know why the Linux omp test is failing?
It seems the nightly CI does not have issues with ubuntu22.04 and omp together. Is there something we are missing in this per-commit ci?

@julianmi
Copy link
Contributor Author

There is a known issue with the use of checkout@v4 and Ubuntu 22.04. See actions/checkout#1667. I'm not aware of a workaround at this point so I don't think it's possible to make all of the proposed changes in the set of move to the latest Ubuntu, Node20, and checkout@v4.

Thank you for making me aware of this. This issue seems to be for outdated self-hosted runners only, right? We should use the GitHub-managed runners and I don't see any error messages with the proposed switch to checkout@v4 and Ubuntu 22.04.

@julianmi
Copy link
Contributor Author

Do we know why the Linux omp test is failing? It seems the nightly CI does not have issues with ubuntu22.04 and omp together. Is there something we are missing in this per-commit ci?

We need to apparently install libomp5 and libomp-dev packages on Ubuntu 22.04. All tests are now green, and we don't have any deprecation messages anymore.

@julianmi julianmi marked this pull request as ready for review July 19, 2024 11:31
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It may be good to get confirmation from someone like @kboyarinov or @Alexandr-Konovalov that there is no need for a specific ubuntu version for the pstl-offload job.

@Alexandr-Konovalov
Copy link
Contributor

It should be no requirement for the specific version of Ubuntu from PSTL offload side.

@julianmi julianmi merged commit 79eabfd into main Jul 24, 2024
21 checks passed
@julianmi julianmi deleted the dev/julianmi/ci_upgrade_actions branch July 24, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants