-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CI versions #1710
Upgrade CI versions #1710
Conversation
There is a known issue with the use of checkout@v4 and Ubuntu 22.04. See actions/checkout#1667. I'm not aware of a workaround at this point so I don't think it's possible to make all of the proposed changes in the set of move to the latest Ubuntu, Node20, and checkout@v4. |
Do we know why the Linux omp test is failing? |
Thank you for making me aware of this. This issue seems to be for outdated self-hosted runners only, right? We should use the GitHub-managed runners and I don't see any error messages with the proposed switch to |
We need to apparently install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, It may be good to get confirmation from someone like @kboyarinov or @Alexandr-Konovalov that there is no need for a specific ubuntu version for the pstl-offload job.
It should be no requirement for the specific version of Ubuntu from PSTL offload side. |
This PR proposes to upgrade the runners' versions to the latest OS to keep the CI running on current environments. This was noticed by @danhoeflinger in #1479 (comment).
ubuntu-latest
(currently 22.04)windows-latest
(currently 2022)macos-latest
(currently 14)It further upgrades the following GitHub actions:
actions/checkout
: warns about using deprecated Node.js 16actions/setup-python
: warns about using deprecated Node.js 16actions/upload-artifact
: warns about deprecationI've also increased the build concurrency to 4 on Linux and Windows to match the core counts on the latest runners. This reduces the test times for these configurations.