Adding Dynamic Selection RFC #2079
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
63
to
68
| // (4) each submission can be waited on using the returned object | ||
| ex::wait(done); | ||
| } | ||
|
|
||
| // (5) and/or all submissions can be waited on as a group | ||
| ex::wait(p.get_submission_group()); |
There was a problem hiding this comment.
We may want to make more clear that in a normal case, one would use 4 or 5, rather than a combination of both?
Comment on lines
82
to
83
| to the Backend. The handle `h` is the mechanism for the Backend to report runtime | ||
| information required by the Policy logic for making future selections. |
There was a problem hiding this comment.
Do we want to mention here a situation where runtime information being reported to the policy is necessary?
| auto &r = resources_[i]; | ||
| return selection_type{*this, r}; | ||
| } else { | ||
| throw std::logic_error(“selected called before initialization”); |
There was a problem hiding this comment.
It seems "selected" is intentional since it is repeated, and probably coming from the code.
I think we would want "selected before initialization" or "select called before initialization".
|
|
||
| May throw `std::bad_alloc` or `std::logic_error`. | ||
|
|
||
| A call to `get_resources` may cause lazy initialization. Initialization may throw `std::bad_alloc`. |
There was a problem hiding this comment.
We probably need to define "lazy initialization" for a backend (and its resources).
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A description of the Dynamic Selection experimental feature. The intent is to capture the current design so that future RFCs can propose changes.