Skip to content

Adding Dynamic Selection RFC #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 8, 2025
Merged

Conversation

vossmjp
Copy link
Contributor

@vossmjp vossmjp commented Feb 25, 2025

A description of the Dynamic Selection experimental feature. The intent is to capture the current design so that future RFCs can propose changes.

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments.
I think this is a nice distillation.

vossmjp and others added 8 commits February 28, 2025 15:07
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
@vossmjp vossmjp requested review from akukanov and rarutyun February 28, 2025 22:12
@vossmjp vossmjp marked this pull request as ready for review February 28, 2025 22:13
@vossmjp vossmjp requested a review from danhoeflinger March 14, 2025 21:23
vossmjp and others added 2 commits March 17, 2025 10:28
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
vossmjp and others added 10 commits March 24, 2025 11:23
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
danhoeflinger
danhoeflinger previously approved these changes Mar 24, 2025
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I think it is an good representation of the existing experimental implementation as it is currently implemented.

@vossmjp vossmjp requested a review from MikeDvorskiy April 1, 2025 18:28
Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>
vossmjp and others added 2 commits April 8, 2025 10:13
Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>
akukanov
akukanov previously approved these changes Apr 8, 2025
Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vossmjp vossmjp merged commit 7089ff2 into main Apr 8, 2025
2 checks passed
@vossmjp vossmjp deleted the dev/vossmjp/dynamic_selection_rfc branch April 8, 2025 18:58
timmiesmith pushed a commit that referenced this pull request Jun 9, 2025
* Adding Dynamic Selection RFC
---------

Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants