Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libc++ from tested Standard C++ APIs #2080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SergeyKopienko
Copy link
Contributor

@SergeyKopienko SergeyKopienko commented Feb 25, 2025

Remove libc++ tested Standard C++ APIs as not tested.
Probably we will restore it when we add xpu_api tests for this standard library together with icpx compiler.

@SergeyKopienko SergeyKopienko changed the title Remove libc++ from tested API Remove libc++ from tested Standard C++ APIs Feb 25, 2025
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fair to me. I confirm that libc++ is not regularly tested.
We can update the table again after testing it manually or setting up automatic testing.

I would suggest waiting for others' opinions, though.

@timmiesmith
Copy link
Contributor

Was this gap introduced when the clang++ driver was removed from the DPC++ compiler distribution? I think in order to test with the clang++ driver we would need to use a build of the https://github.com/intel/llvm.

@SergeyKopienko
Copy link
Contributor Author

Was this gap introduced when the clang++ driver was removed from the DPC++ compiler distribution? I think in order to test with the clang++ driver we would need to use a build of the https://github.com/intel/llvm.

https://www.intel.com/content/www/us/en/developer/articles/troubleshooting/sourcing-oneapi-overrides-existing-clang-drivers.html : "The oneAPI provided clang/clang++ drivers were not intended to be used by customers..."

@SergeyKopienko SergeyKopienko added this to the 2022.9.0 milestone Feb 26, 2025
@akukanov
Copy link
Contributor

@timmiesmith can this patch be retargeted to 2022.8 (and the respective branch) instead, or is it already late?

@timmiesmith
Copy link
Contributor

@timmiesmith can this patch be retargeted to 2022.8 (and the respective branch) instead, or is it already late?

I think we're too late for inclusion in the oneAPI 2025.1 release, but we can pull this into the 2022.8.0 release branch so the open source release has the correct status.

@SergeyKopienko
Copy link
Contributor Author

@timmiesmith can this patch be retargeted to 2022.8 (and the respective branch) instead, or is it already late?

I think we're too late for inclusion in the oneAPI 2025.1 release, but we can pull this into the 2022.8.0 release branch so the open source release has the correct status.

I have prepared separate PR #2086 for 2022.8

@SergeyKopienko SergeyKopienko force-pushed the dev/skopienko/remove_libc++_from_tested_api branch 3 times, most recently from 9c1314f to 442e5e0 Compare March 5, 2025 17:17
…api.rst - remove libc++ standard library from tested API
@SergeyKopienko SergeyKopienko force-pushed the dev/skopienko/remove_libc++_from_tested_api branch from 442e5e0 to 20c144d Compare March 6, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants