-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for blocked_nd_range CTAD #1641
Add documentation for blocked_nd_range CTAD #1641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one typo
Co-authored-by: Alexandra <alexandra.epanchinzeva@intel.com>
========================================= | ||
|
||
.. note:: | ||
To enable this feature, define the ``TBB_PREVIEW_BLOCKED_ND_RANGE_DEDUCTION_GUIDES`` macro to 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add link to RFC so people know where to leave feedback and what the exit conditions are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done as a separate note in the description
Deduction (starting from C++17). With that, you do not need to specify template arguments explicitly | ||
while creating a ``blocked_nd_range`` object if they can be inferred from the constructor arguments: | ||
|
||
.. literalinclude:: ./examples/blocked_nd_range_ctad_example.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the blocked_nd_range_ctad_example.cpp file missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. I cannot find this file in ./examples
subdirectory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Co-authored-by: Mike Voss <michaelj.voss@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for the comment below.
Deduction (starting from C++17). With that, you do not need to specify template arguments explicitly | ||
while creating a ``blocked_nd_range`` object if they can be inferred from the constructor arguments: | ||
|
||
.. literalinclude:: ./examples/blocked_nd_range_ctad_example.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. I cannot find this file in ./examples
subdirectory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
Extend reference with the information about blocked_range deduction guides (preview feature).
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information