add option for generating release pdb files #1655
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaevil
reviewed
Feb 26, 2025
Comment on lines
+79
to
+82
| if (TBB_RELEASE_PDB AND CMAKE_BUILD_TYPE MATCHES "Release") | ||
| set(TBB_LIB_COMPILE_FLAGS ${TBB_LIB_COMPILE_FLAGS} /Zi) | ||
| set(TBB_LIB_LINK_FLAGS ${TBB_LIB_LINK_FLAGS} /DEBUG /OPT:REF /OPT:ICF) | ||
| endif() |
There was a problem hiding this comment.
Isn't it essentially the same as RelWithDebInfo? Meaning you'll have same /Zi and /DEBUG flags there and .pdb files as well.
There was a problem hiding this comment.
RelWithDebInfo also changes its default for inlined functions from /Ob2 in Release to /Ob1 in RelWithDebInfo
Not sure, how it affects TBB performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option for generating pdb files when building release libraries, the default value is OFF.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information