SYCL CTS CI for riscv64 qemu #701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-forbes-cp
changed the title
alan-forbes-cp
commented
Mar 6, 2025
| - '.github/workflows/run_pr_tests.yml' | ||
| - '.github/workflows/run_pr_tests_caller.yml' | ||
| - 'CMakeLists.txt' | ||
| #pull_request: |
There was a problem hiding this comment.
Remove all temporary updates added to facilitate development testing.
alan-forbes-cp
changed the title
alan-forbes-cp
commented
Mar 6, 2025
| @@ -305,18 +306,18 @@ jobs: | |||
| download_dpcpp_artefact: ${{ inputs.download_dpcpp_artefact }} | |||
|
|
|||
| build_sycl_cts: | |||
| needs: [workflow_vars, build_icd, build_dpcpp_native] | |||
| needs: [workflow_vars, build_icd, build_dpcpp_native, build_dpcpp_cross] | |||
There was a problem hiding this comment.
There's a slight gotcha here in that build_dpcpp_cross is now only needed for riscv64 (true also for SYCL CTS run job below).
If riscv64 is excluded from the target_list and this setting is retained then the SYCL CTS build job will not fire.
However, this is not currently an issue for production. Comments welcome.
There was a problem hiding this comment.
yes it's a bit icky the dependencies, we could either fire build_dpcc_cross regardless (but do nothing if not needed) or we use the json method we've used elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add SYCL CTS tests for riscv64 qemu
Reason for change
Add remaining architecture, plus qemu support.
Description of change
planned_testingSYCL CTS build/run with support for riscv64 plus correct container image.$PREPEND_PATHvar)Anything else we should know?