Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support agent on windows #72

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

support agent on windows #72

wants to merge 16 commits into from

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Feb 21, 2025

What changed

  • installer support
    • old agent.bat (can ditch this at some point)
    • YML workflow to build msi
    • .wxs file for MSI
  • utils
    • config.go: add two Disabled() getters to always disable some subsystems on windows (regardless of config)
    • utils.go: path setup, factor our checkPathOwner, auto-add .exe extension, fix some file handling errors, do netsh
    • make Kill and SyncFS platform-dependent
    • add KillTree
  • main.go
    • factor out big chunks that don't work on win yet: runPlatformProvisioning, waitOnline
    • add main_windows.go which manages a windows service

Why

Support agent on windows

Manual testing

  • on windows:
    • test start / stop (including RDK module processes)
    • test upgrading RDK + agent
  • test to make sure linux hasn't been broken

@abe-winter abe-winter requested a review from ale7714 March 11, 2025 00:50
@abe-winter abe-winter marked this pull request as ready for review March 11, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant