[RSDK-7007] Add Manifest Generation in CI #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otterverse
changed the title
abe-winter
approved these changes
Mar 4, 2025
| fi | ||
|
|
||
| # Set platform based on architecture in binary name | ||
| if [[ "$BINARY_NAME" == *"x86_64"* ]]; then |
There was a problem hiding this comment.
I say this in the tone of the trailer for a horror movie but remember, windows is coming
linux/amd64 isn't the only amd64 anymore
I think you need to do one of:
- handle
*windows-x86_64first, and make sure*x86_64is an else case - always include OS in the filename
There was a problem hiding this comment.
Good call. I'd been trying not to do ANYTHING windows here, to not conflict with your PR, but obviously new stuff in CI wouldn't be in your PR anyway.
Updated this to handle OS and Arch separately, so windows should work.
There was a problem hiding this comment.
you're assuming I haven't created an entire parallel manifest system on my branch that will lead to terrible merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add manifest generation to agent builds, to support incoming work in App.