-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update numbered list styling #4013
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hmm it's splitting to the next line in places like https://deploy-preview-4013--viam-docs.netlify.app/operate/get-started/other-hardware/#write-your-module and https://deploy-preview-4013--viam-docs.netlify.app/operate/get-started/other-hardware/manage-modules/: I think the squares look very similar to our buttons (like Ask AI) and other boxes like command prompt examples. I know we're a box shop not a circles shop but I think circles would be clearer. Maybe Cristina can help make these different somehow. We do have some rounded elements like below and like the machine online indicator in the app. |
4905b97
to
d891dd4
Compare
I think possibly all fixed now but will want to check a bit more thoroughly |
It's the custom number styling that's causing this - only fix is to use raw markdown or javascript. However, I think the content is the issue here because it closes the ordered list and starts a new one which isn't really semantically correct. If there's such complex content for a list item that it breaks the list rendering maybe that's where we draw the line and make it a tablestep where we can have more control over the rendering |
Hmm we frequently have expanders within steps though--this step isn't extra-complex except that it is all within a tab. If the expander could be indented, that would fix the numbering problem, but we can't indent an expander within a tab without the expander formatting breaking. So, the numbering problem would be fixed if we could fix the indented-expander-inside-a-tab issue. |
ba062c8
to
8b96aa9
Compare
8b96aa9
to
96f0c79
Compare
96f0c79
to
66b1fa5
Compare
No description provided.