-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli.md #4031
Update cli.md #4031
Conversation
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so, if you run viam machines part run -h
now, you see --organization
and not the other aliases. So maybe we should turn these all back to --organization
as well as in the table. Or, if you want --org-id
, change the table to match since right now the table says --org
. I went with --org
before because it was the shortest and wasn't certain how things would end up changing anyway.
Ok, so that is then actually a third inconsistency but that one can be a ticket for the SDK team, the docs can already change. Unless I am wrong that the default is not |
Not sure I follow. By default, do you mean the flag help spits out, which is |
one of the aims of the project to make the cli command flags consistent was to default to one consistent flag where there are multiple different options across commands. I believe the flag name that should be used across all commands is org-id, is that correct? If so the changes I made here should happen. The help text seems to not align with the project goals. Since using org-id works, we can already change to this in the docs and then ask the sdk team to clean up the inconsistency. |
So if I'm not mistaken, the SDK team chose to keep
What I think we should do is, in this PR, change the current instances of In tables such as the |
Let's change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)' |
No description provided.