-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten fragment reuse guide #4033
Conversation
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % small comments
**2. Copy the raw JSON** | ||
|
||
In your machine's **CONFIGURE** tab, switch to **JSON** and copy the raw JSON configuration object. | ||
**3. Switch to JSON and copy the raw JSON configuration object**. | ||
|
||
{{<imgproc src="/how-tos/one-to-many/raw-json.png" resize="700x" class="shadow fill" style="width: 400px" declaredimensions=true alt="JSON subtab of the CONFIGURE tab">}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[opt] Now with the red box, I worry folks might lose the focus on actually copying the JSON text itself. Consider taking a screenshot where the JSON config is selected, ready to copy
@@ -401,16 +386,14 @@ Fragment overwrites are currently _not_ supported for modifying [triggers](/mana | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[out of diff] Do we still need to say "Fragment overwrites are currently not supported for modifying triggers" if triggers themselves aren't supported in fragments?
Co-authored-by: Jessamy Taylor <75634662+JessamyT@users.noreply.github.com>
Co-authored-by: Jessamy Taylor <75634662+JessamyT@users.noreply.github.com>
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)' |
No description provided.