Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten fragment reuse guide #4033

Merged
merged 5 commits into from
Mar 5, 2025
Merged

Conversation

npentrel
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 44df18d
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67c84c526346da0008983e5c
😎 Deploy Preview https://deploy-preview-4033--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 22 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@npentrel npentrel changed the title Change to be more procedural Shorten fragment reuse guide Feb 21, 2025
Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % small comments

**2. Copy the raw JSON**

In your machine's **CONFIGURE** tab, switch to **JSON** and copy the raw JSON configuration object.
**3. Switch to JSON and copy the raw JSON configuration object**.

{{<imgproc src="/how-tos/one-to-many/raw-json.png" resize="700x" class="shadow fill" style="width: 400px" declaredimensions=true alt="JSON subtab of the CONFIGURE tab">}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[opt] Now with the red box, I worry folks might lose the focus on actually copying the JSON text itself. Consider taking a screenshot where the JSON config is selected, ready to copy

@@ -401,16 +386,14 @@ Fragment overwrites are currently _not_ supported for modifying [triggers](/mana

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[out of diff] Do we still need to say "Fragment overwrites are currently not supported for modifying triggers" if triggers themselves aren't supported in fragments?

npentrel and others added 3 commits March 5, 2025 13:53
Co-authored-by: Jessamy Taylor <75634662+JessamyT@users.noreply.github.com>
Co-authored-by: Jessamy Taylor <75634662+JessamyT@users.noreply.github.com>
@npentrel npentrel merged commit f14a1d3 into viamrobotics:main Mar 5, 2025
12 checks passed
Copy link

github-actions bot commented Mar 5, 2025

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants