RSDK-9607: add build and run options for all Python modules; remove run option for Go #4818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
purplenicole730
changed the title
viambot
added
safe to test
viambot
added
safe to test
purplenicole730
force-pushed
the
RSDK-9607-generate-run.sh-and-populate-build-command
branch
from
5d840b6 to
9b23811
Compare
viambot
added
safe to test
purplenicole730
force-pushed
the
RSDK-9607-generate-run.sh-and-populate-build-command
branch
from
9b23811 to
7f02db9
Compare
viambot
added
safe to test
njooma
reviewed
Mar 5, 2025
| from viam.module.module import Module | ||
| from .models.{{ .ModelSnake }} import {{ .ModelPascal }} | ||
| sys.path.append(os.path.dirname(os.path.abspath(__file__))) |
There was a problem hiding this comment.
What is this for? I don't like the idea of updating the path...
There was a problem hiding this comment.
Running build.sh and run.sh both fail in opposite ways. Using the relative path .models fails when using the hot reloading method, but succeeds when just writing models. run.sh can't find models, but can find .models. If there's a better way for both methods to find models, that would definitely be best. Python import errors are my nemesis
There was a problem hiding this comment.
can we use a try/except block when importing here, along with a comment explaining the details?
stuqdog
reviewed
Mar 5, 2025
viambot
added
safe to test
viambot
added
safe to test
stuqdog
reviewed
Mar 6, 2025
Comment on lines
6
to
9
| from models.hello_sensor import HelloSensor | ||
| except ModuleNotFoundError: | ||
| # when running as local module with run.sh | ||
| from .models.hello_sensor import HelloSensor |
There was a problem hiding this comment.
Probably we still want ModelSnake and ModelPascal, rather than hard-coding HelloSensor
There was a problem hiding this comment.
omg 😅 That would have been embarrassing!
There was a problem hiding this comment.
Fixed with my new commit: please pay attention nicole
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
purplenicole730
deleted the
RSDK-9607-generate-run.sh-and-populate-build-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, users could only use the
run.shscript for local Python modules, and only hot reloading for cloud Python modules. Both methods should be available for both, even if there's a default. Go should never be usingrun.sh, as a user should not be building a Go binary on an embedded device every time a module is updated or restarted.Changes:
run.shfrom Golang modulesFlyby:
Testing Process:
do_commandto print a log.run.sh.do_command()from a sensor using local Python module -- ✅do_command()from a sensor using cloud Python module -- ✅make setupandmake builddo_command()from a sensor using local Go module -- ✅do_command()from a sensor using cloud Go module -- ✅do_command()from a sensor using local Python module -- ✅do_command()from a sensor using cloud Python module -- ✅