20250301 go template tweaks #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
penguinland
reviewed
Mar 1, 2025
| @@ -49,22 +45,15 @@ func (cfg *Config) Validate(path string) ([]string, error) { | |||
| } | |||
|
|
|||
| type {{.ModelType}} struct { | |||
| resource.AlwaysRebuild | |||
There was a problem hiding this comment.
👍 Great idea here! AlwaysRebuild should be the default used by 98% of components and services.
| ) | ||
|
|
||
| func main() { | ||
| err := realMain() |
There was a problem hiding this comment.
What's the purpose of this file? It seems to construct the resource and immediately shut everything down. Why bother?
There was a problem hiding this comment.
yes, it's so people know they can do it and boiler plate
| deps := resource.Dependencies{} | ||
| // can load these from a remote moachine if you need | ||
|
|
||
| cfg := {{.ModuleLowercase}}.Config{} |
There was a problem hiding this comment.
Many resources have config fields that are required to be non-empty, so this feels wrong. but the resource constructed isn't used, so maybe it's okay...
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just went with the reviewer suggestions, no idea if these are right