[RSDK-9280] - Make image_file not encode when reading from image file #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
|
How was CPU usage/memory before and after? |
Ran pprof profiling CPU usage for 60 seconds with only a image_file livestream going. Same config between feature vs. main Main: total cpu was 41.9s |
viambot
added
safe to test
with htop Main: CPU cores ~259% |
randhid
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested stream and manual refresh for a color image locally
Tested with bunny pcd static
Tested with
.artifact/data/rimage/fakeDM.vnd.viam.depon par with
mainbranch