[RSDK-7007] Update CI to build semver "dev" versions for latest #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
abe-winter
approved these changes
Mar 4, 2025
| @@ -0,0 +1,43 @@ | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
optional nit, would set -e here for bash hygiene
| # Set PATH_VERSION based on TAG_VERSION | ||
| PATH_VERSION="v${TAG_VERSION}" | ||
|
|
||
| echo ${PATH_VERSION} |
There was a problem hiding this comment.
this file is good but will be very funky when someone else touches it I suspect. this is non-blocking, but would like to add a test for this
(doesn't have to be you -- assign tests to me if you want)
There was a problem hiding this comment.
Agree tests would be good, but not urgent (there's likely some more tweaks that'll be needed here anyway.) Created https://viam.atlassian.net/browse/RSDK-10159 for whenever we get to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd been building "latest" as timestamp (20250304121314) style "versions." This switches to using a semantic version compatible format with a "dev" prerelease tag. It also embeds that version properly in builds.
This will be picked up by upcoming changes in App, along with similar work for Agent.