Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-10041 - better warnings on out-of-date CLI #4829

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

stuqdog
Copy link
Member

@stuqdog stuqdog commented Mar 4, 2025

Adds better warnings on out-of-date CLI. The logic flow is as such:

  • Determine the local version and the latest version.
    -- if both can be determined and the local version is older than the latest version, emit warning and return
    -- if both can be determined and the local version is not older than the latest version, then emit no warning and return
  • if local version and/or latest version can't be determined, then determine when the binary was built.
    -- if we can't determine when the binary was built, return
    -- if we can determine when the binary was built, emit a warning if it's more than a week old

Tested locally by artificially amending the version tag and build window (from one week to one second), confirmed the cases worked as described.

@stuqdog stuqdog requested review from a team, njooma and lia-viam and removed request for a team March 4, 2025 22:27
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Mar 4, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 5, 2025
@stuqdog stuqdog merged commit b12ac80 into viamrobotics:main Mar 5, 2025
16 checks passed
@stuqdog stuqdog deleted the RSDK-10041-warn-on-outdated-cli branch March 5, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants