[RSDK-9928] - Add preloaded images to image_file camera #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
hexbabe
changed the title
randhid
reviewed
Mar 5, 2025
components/camera/fake/image_file.go
Outdated
| "errors" | ||
| "fmt" | ||
| "image" | ||
| "image/png" |
There was a problem hiding this comment.
Does fake camera use png or jpeg for the worlddata image?
There was a problem hiding this comment.
should we use that here? It should lead to a smaller file I think.
There was a problem hiding this comment.
fake camera with rtp passthrough true still shows the world data. ✅
image_file camera can reconfigure from preloaded data to image file and back. ✅
There was a problem hiding this comment.
To test ae1d862, I ran my feature branch viam-server and re-tested that the pizza, crowd, and dog render properly on app
verifying the new jpeg decoding works
There was a problem hiding this comment.
New file is 165kb down from 477kb with png
viambot
added
safe to test
randhid
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-9928
This PR makes a new additive non-breaking attribute
preloaded_imagethat is"pizza" | "dog" | "crowd". If specified, it will use the base64 representation of said images in the modified fileworlddata.go->fakedata.gowhich used to only contain the world asset for thefakecamera rtp passthrough stream, but now also includes these preloaded images.There is validation in
Validateto make sure that only"pizza" | "dog" | "crowd"is specified whenpreloaded_imageis given.Imageswill also return the specified preloaded image along with other configured filenames.I also added tests to make sure the camera initializes properly with the field specified and checked outputs of
ImageandImagesThe additional images increases our fake assets from 11kb to 477kb.
Manual testing
pizza dog crowd
